Better tint support #298
Better tint support #298
Conversation
|
Failed the test due to #302. |
| s.license = { :type => 'MIT', :file => 'LICENSE.txt' } | ||
| s.author = { "Tom Benner" => "[email protected]" } | ||
| s.source = { :git => "https://github.com/tombenner/nui.git", :tag => "v0.5.5" } | ||
| s.source = { :git => "https://github.com/Joulebug/nui.git", :tag => "v0.5.6" } |
There was a problem hiding this comment.
If you need an intermediary release of your own fork, please make such changes on a different branch than you're using to file a pull request.
|
The The identically named attributes already existed on some other classes such as UIBarButtonItem or UINavigationBar since iOS 5. When the
My suggestion would be to set the barTintColor with the background-color attribute on iOS 7 and higher for these classes, instead of the tintColor. For |
|
Note: While this shouldn't be a big problem for NUI, it would be better to check for capabilities at runtime by calling |
|
I'm the lead on this project now (wow, it's been awhile). I see the previous PR added bar-tint-color for UISearchBar, could we do something similar for the other Bar classes? |
Merge in latest nui
joeboyscout04
force-pushed
the
tint-support
branch
from
7bc51e3
to
944b068
Compare
# Conflicts: # Demo/NUIDemo.xcworkspace/xcshareddata/NUIDemo.xccheckout # NUI/Core/Renderers/NUINavigationBarRenderer.m # NUI/Core/Renderers/NUITabBarRenderer.m # NUI/Core/Renderers/NUITextViewRenderer.m # README.md
We had a need for better support for the tint options in iOS. I added code to make that happen. In some cases, the tint color was being controlled by the NUI background-tint-color property. This struck me as poorly named, since the tint color doesn't always affect just the background. I renamed these to tint-color where appropriate. I did leave support for the old name, but the new name will supersede the old if both exist in the configuration.